Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide hidden quests and block disabled ones #52

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

Th0rgal
Copy link
Member

@Th0rgal Th0rgal commented Jul 31, 2023

This pull request replaces the "disabled" field from existing quests collection scheme by two new fields. Disabling a quest used to just be front end trick to hide a quest from the front page of the website. People could still find the quest id by looking at the API result and access it. Here is how this feature changes that:

1) disabled

A disabled quest won't be accessible. You won't be able to find it in the list of quests, nor fetch the actual quest document required to display the quest page. Endpoints allowing to complete the tasks of this quest will still work so we should still update the quest server when we remove a quest, but this allows us to keep the database as it is.

2) hidden

This is similar to what we used to do when disabling quests, except this is server-side. You can still access the actual quest page, but even if you look at the API result, you won't be able to find the quest_id in the returned json.

Copy link
Collaborator

@irisdv irisdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Th0rgal Th0rgal merged commit 818457e into master Jul 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants